[ExecuTorch] Add broadcasting support to optimized op_div #8257
+68
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Similar to broadcast support in op_mul Test Plan: Tests added Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Feb 6, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8257
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit f1aef94 with merge base b71d873 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Feb 6, 2025
kimishpatel
added a commit
that referenced
this pull request
Feb 6, 2025
Summary: Similar to broadcast support in op_mul Test Plan: Tests added Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: e7ddbae6816868a4192515a80931f7391a21014b Pull Request resolved: #8257
facebook-github-bot
added
the
CLA Signed
Summary: Similar to broadcast support in op_mul Test Plan: Tests added Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
kimishpatel
added a commit
that referenced
this pull request
Feb 6, 2025
Summary: Similar to broadcast support in op_mul Test Plan: Tests added Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 3466308811438b430f0c89237e8f16cd24b878d0 Pull Request resolved: #8257
kimishpatel
added
module: kernels
Summary: Similar to broadcast support in op_mul Test Plan: Tests added Reviewers: Subscribers: Tasks: Tags: cc larryliu0820 manuelcandales [ghstack-poisoned]
kimishpatel
added a commit
that referenced
this pull request
Feb 7, 2025
Summary: Similar to broadcast support in op_mul Test Plan: Tests added Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 1972c976a836234e865da17d1bb0887f7167a91d Pull Request resolved: #8257
Summary: Similar to broadcast support in op_mul Test Plan: Tests added Reviewers: Subscribers: Tasks: Tags: cc larryliu0820 manuelcandales [ghstack-poisoned]
kimishpatel
added a commit
that referenced
this pull request
Feb 7, 2025
Summary: Similar to broadcast support in op_mul Test Plan: Tests added Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: c9d05c8405401e10a45a08c3e160aa04eaf1be86 Pull Request resolved: #8257
Summary: Similar to broadcast support in op_mul Test Plan: Tests added Reviewers: Subscribers: Tasks: Tags: cc larryliu0820 manuelcandales [ghstack-poisoned]
kimishpatel
added a commit
that referenced
this pull request
Feb 11, 2025
Summary: Similar to broadcast support in op_mul Test Plan: Tests added Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 4f87bdb5137decc275d3298e535d75b00f5fad61 Pull Request resolved: #8257
Summary: Similar to broadcast support in op_mul Test Plan: Tests added Reviewers: Subscribers: Tasks: Tags: cc larryliu0820 manuelcandales [ghstack-poisoned]
kimishpatel
added a commit
that referenced
this pull request
Feb 11, 2025
Summary: Similar to broadcast support in op_mul Test Plan: Tests added Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: f50384ed1d5be11665dadf09a0a410b63e212740 Pull Request resolved: #8257
swolchok
approved these changes
Feb 11, 2025
kernels/optimized/cpu/op_div.cpp
Outdated
| // Reason for using alpha is becasuse handle_broadcast_elementwise | ||
| // is used for add and sub as well: | ||
| static constexpr const char op_name[] = "div.out"; | ||
| ET_SWITCH_REALB_TYPES(out_type, ctx, "mul.out", CTYPE, [&]() { |
|
@kimishpatel has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Similar to broadcast support in op_mul Test Plan: Tests added Reviewers: Subscribers: Tasks: Tags: cc larryliu0820 manuelcandales Differential Revision: [D69491815](https://our.internmc.facebook.com/intern/diff/D69491815) [ghstack-poisoned]
kimishpatel
added a commit
that referenced
this pull request
Feb 12, 2025
Summary: Similar to broadcast support in op_mul Test Plan: Tests added Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 062635bd1539621beae14173ba34392aebe24fff Pull Request resolved: #8257
Summary: Similar to broadcast support in op_mul Test Plan: Tests added Reviewers: Subscribers: Tasks: Tags: cc larryliu0820 manuelcandales Differential Revision: [D69491815](https://our.internmc.facebook.com/intern/diff/D69491815) [ghstack-poisoned]
kimishpatel
added a commit
that referenced
this pull request
Feb 12, 2025
Summary: Similar to broadcast support in op_mul Test Plan: Tests added Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: bedf1efce039b81d9ccd508745729581845a00f1 Pull Request resolved: #8257
|
@kimishpatel has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Similar to broadcast support in op_mul Test Plan: Tests added Reviewers: Subscribers: Tasks: Tags: cc larryliu0820 manuelcandales Differential Revision: [D69491815](https://our.internmc.facebook.com/intern/diff/D69491815) [ghstack-poisoned]
kimishpatel
added a commit
that referenced
this pull request
Feb 12, 2025
Summary: Similar to broadcast support in op_mul Test Plan: Tests added Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: ac6fb8149912da64ef1007ee760154fd89b5cfb4 Pull Request resolved: #8257
Summary: Similar to broadcast support in op_mul Test Plan: Tests added Reviewers: Subscribers: Tasks: Tags: cc larryliu0820 manuelcandales Differential Revision: [D69491815](https://our.internmc.facebook.com/intern/diff/D69491815) [ghstack-poisoned]
kimishpatel
added a commit
that referenced
this pull request
Feb 12, 2025
Summary: Similar to broadcast support in op_mul Test Plan: Tests added Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 67bc2ab59dc6bd68bd1a1ee5a9899ce1b89eb9db Pull Request resolved: #8257
|
@kimishpatel has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Similar to broadcast support in op_mul Test Plan: Tests added Reviewers: Subscribers: Tasks: Tags: cc larryliu0820 manuelcandales Differential Revision: [D69491815](https://our.internmc.facebook.com/intern/diff/D69491815) [ghstack-poisoned]
kimishpatel
added a commit
that referenced
this pull request
Feb 13, 2025
Summary: Similar to broadcast support in op_mul Test Plan: Tests added Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: ff509c7696468a695d270747e3f0a00533b5991f Pull Request resolved: #8257
manuelcandales
approved these changes
Feb 13, 2025
Summary: Similar to broadcast support in op_mul Test Plan: Tests added Reviewers: Subscribers: Tasks: Tags: cc larryliu0820 manuelcandales Differential Revision: [D69491815](https://our.internmc.facebook.com/intern/diff/D69491815) [ghstack-poisoned]
kimishpatel
added a commit
that referenced
this pull request
Feb 13, 2025
Summary: Similar to broadcast support in op_mul Test Plan: Tests added Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 762829c55fade2ad97e269fe803d5fde6d7bf0d2 Pull Request resolved: #8257
Summary: Similar to broadcast support in op_mul Test Plan: Tests added Reviewers: Subscribers: Tasks: Tags: cc larryliu0820 manuelcandales Differential Revision: [D69491815](https://our.internmc.facebook.com/intern/diff/D69491815) [ghstack-poisoned]
kimishpatel
added a commit
that referenced
this pull request
Feb 15, 2025
Summary: Similar to broadcast support in op_mul Test Plan: Tests added Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 299a2786bd3fcd4e73c1622a335245c5cef6a6a2 Pull Request resolved: #8257
|
@kimishpatel has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Similar to broadcast support in op_mul Test Plan: Tests added Reviewers: Subscribers: Tasks: Tags: cc larryliu0820 manuelcandales Differential Revision: [D69491815](https://our.internmc.facebook.com/intern/diff/D69491815) [ghstack-poisoned]
kimishpatel
added a commit
that referenced
this pull request
Feb 15, 2025
Summary: Similar to broadcast support in op_mul Test Plan: Tests added Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: f765411389f84e4629fd6c5232a703d7409b5b07 Pull Request resolved: #8257
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
Similar to broadcast support in op_mul
Test Plan:
Tests added
Reviewers:
Subscribers:
Tasks:
Tags:
cc @larryliu0820 @manuelcandales
Differential Revision: D69491815